Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(portals): dispose portalhost when destroyed #1703

Merged
merged 1 commit into from
Nov 3, 2016

Conversation

andrewseguin
Copy link
Contributor

No description provided.

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Nov 2, 2016
@andrewseguin
Copy link
Contributor Author

Would it make sense to also add an onDestroy to the TemplatePortalDirective as well (detach itself from the host on destroy)

@jelbourn
Copy link
Member

jelbourn commented Nov 3, 2016

LGTM

@andrewseguin We don't want to have the portal detach itself because the template may be rendered in a host somewhere completely separated from where the portal originally came from.

However, we should also make this change to DomPortalHost
(but wait for #1704 to go in before doing that)

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Nov 3, 2016
@jelbourn jelbourn merged commit 7e08468 into angular:master Nov 3, 2016
@andrewseguin andrewseguin deleted the portal-memory branch November 11, 2016 22:58
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants